Skip to content

Fix table group join issue with subclasses #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Aug 11, 2022

Problematic scenario: invalid SQL is generated when joined entity with subclasses doesn't need subclass joins

//inner joined animal is not used in output (no need to join subclasses)
var resultsFromOuter1 = db.Animals.Join(db.Animals, o => o.Id, i => i.Id, (o, i) => o).Take(1).ToList();

@bahusoid bahusoid changed the title WIP Fix table group join issue Fix table group join issue Aug 11, 2022
@fredericDelaporte fredericDelaporte added this to the next minor milestone Aug 16, 2022
@hazzik hazzik changed the title Fix table group join issue Fix table group join issue with subclasses Aug 16, 2022
@hazzik hazzik merged commit 1793699 into nhibernate:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants