Skip to content

Add datetimex keyword to SapSQLAnywhere17Dialect #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Sep 1, 2022

After upgrade to SQL Anywhere to 17.0.11 the test started failing.

@hazzik hazzik enabled auto-merge (squash) September 1, 2022 05:14
@hazzik hazzik added the r: Fixed label Sep 1, 2022
@bahusoid
Copy link
Member

bahusoid commented Sep 1, 2022

What test? I suspect it's not the only missing keyword. Can you execute SELECT * FROM sa_reserved_words(); and compare results with SapSQLAnywhere17Dialect.Keywords. Or do we already have some test that checks for all reserved words?

@hazzik
Copy link
Member Author

hazzik commented Sep 1, 2022

Or do we already have some test that checks for all reserved words?

yes. SchemaMetadataUpdaterFixture.EnsureReservedWordsHardCodedInDialect

 ======= Failed test run #1 ==========
  Expected: equivalent to < "add", "aes_decrypt", "all", "alter", "and", "any", "array", "as", "asc", "attach"... >
  But was:  < "add", "aes_decrypt", "all", "alter", "and", "any", "array", "as", "asc", "attach"... >
  Missing (1): < "datetimex" >

   at NHibernate.Test.Tools.hbm2ddl.SchemaMetadataUpdaterTest.SchemaMetadataUpdaterFixture.EnsureReservedWordsHardCodedInDialect() in D:\BuildAgent\work\30546188361a242\src\NHibernate.Test\Tools\hbm2ddl\SchemaMetadataUpdaterTest\SchemaMetadataUpdaterFixture.cs:line 112

------- Stdout: -------
Update Dialect SapSQLAnywhere17Dialect with RegisterKeyword:
  RegisterKeyword("datetimex");

======= Failed test run #2 ==========
Expected: equivalent to < "add", "aes_decrypt", "all", "alter", "and", "any", "array", "as", "asc", "attach"... >
  But was:  < "add", "aes_decrypt", "all", "alter", "and", "any", "array", "as", "asc", "attach"... >
  Missing (1): < "datetimex" >
at NHibernate.Test.Tools.hbm2ddl.SchemaMetadataUpdaterTest.SchemaMetadataUpdaterFixture.EnsureReservedWordsHardCodedInDialect() in D:\BuildAgent\work\30546188361a242\src\NHibernate.Test\Tools\hbm2ddl\SchemaMetadataUpdaterTest\SchemaMetadataUpdaterFixture.cs:line 112

https://teamcity.jetbrains.com/viewLog.html?buildId=3938916&tab=buildResultsDiv&buildTypeId=NHibernate_NHibernateSapSqlAnywhere

@hazzik hazzik merged commit 2fd7f0f into nhibernate:master Sep 1, 2022
@hazzik hazzik deleted the sqlAnywhere17-keyword branch September 1, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants