Skip to content

NH-3747 - Unit tests and fixes for aggregate predicates #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2015

Conversation

gliljas
Copy link
Member

@gliljas gliljas commented Jan 3, 2015

No description provided.

public static bool IsGroupingKey(this MemberExpression expression)
{
return expression.Member.Name == "Key" && expression.Member.DeclaringType!=null &&
expression.Member.DeclaringType.GetGenericTypeDefinition() == typeof (IGrouping<,>);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check that DeclaringType is generic type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! Will fix

@hazzik hazzik added this to the 4.1.0 milestone Jan 3, 2015
hazzik added a commit that referenced this pull request Feb 22, 2015
NH-3747 - Unit tests and fixes for aggregate predicates
@hazzik hazzik merged commit 262ac22 into nhibernate:master Feb 22, 2015
@gliljas gliljas deleted the NH-3747 branch December 19, 2016 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants