NH-3759 - uuid.hex id generator fix in mapping by code. Parameters added and retur... #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn type set to string
| } | ||
|
|
||
| public System.Type DefaultReturnType | ||
| { | ||
| get { return typeof(Guid); } | ||
| get { return typeof(string); } |
There was a problem hiding this comment.
the uuid.hex generator returns a string not a guid. Am I missing something?
hazzik
added a commit
that referenced
this pull request
Feb 22, 2015
uuid.hex id generator fix in mapping by code. Parameters added and retur...
|
@lnu do we have JIRA for this? If not, could you please create one? |
lnu
changed the title
lnu
changed the title
|
Thanks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use uuid.hex in the NHibernate.AspNet.Identity project. Right now a custom mapper is implemented in the project. It could be avoided with this fix.