Nh 3771 - Batch Update with Optimistic Locking control. #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a suggestion for batch update when optimistic control. Now, when version control is active, batch update is not done, see the fixture. This is a down side in performance. We made the change, and run the tests. The diference is that StaleStateException is thrown instead of StaleObjectStateException, in which case we loose the information regarding the entity and it's id that generate the exception. In our application, this is not a big problem, compare with the possibility of doing a batch operation instead a single one. We have been looking at the source code, and will be a possibility to still get a class and a group of id's on the batcher to generate a more accurate exception. Please, let me know if this will be of intereset, so i can go deeper in that aproach, or if you see another aproach that you will suggest.
…-3771 # Conflicts: # src/NHibernate.Test/DriverTest/FirebirdClientDriverFixture.cs
If the driver doesn't support batching will throw a StaleObjectState andif does StaleState... Is possible to modify the batcher to throw an StaleObjectState exception in this case... let me know if it's worth it to go in this direction.
|
The 7290c0d commit should not really be a port of this should it? At least, that change appears to already be on master under a different commit id. Rebase? |
|
Hi @tikuna, can you please enable Allow edits from maintainers feature? |
|
I would prefer this to be implemented as "isJdbcBatchVersionedData" (the better name is welcome). |
|
Replaced by #606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nhibernate.jira.com/browse/NH-3771
This is a suggestion for batch update when optimistic control. Now, when
version control is active, batch update is not done, see the fixture (3771).
This is a down side in performance.
We made the change, and run the tests. The diference is that
StaleStateException is thrown instead of StaleObjectStateException, in
which case we loose the information regarding the entity and it's id
that comes with the exception. In our application, this is not a big problem, compare with the
possibility of doing a batch operation instead a single one.
We have been looking at the source code, and will be a possibility to
still get a class and a group of id's on the batcher to generate a more
accurate exception.
Please, let me know if this will be of intereset, so i can go deeper in
that aproach, or if you see another aproach that you will suggest.