NH-3414 - Fixes ORDER BY HQL grammar #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
changed the title
|
@PleasantD new tests are failing for Firebird with "Dynamic SQL Error" in SetUP. Can you please take a look? |
PleasantD
force-pushed
the
NH-3414
branch
2 times, most recently
from
8469e61 to
3cb3aed
Compare
|
Fixed and squashed. Firebird didn't like that the column name was "Value". |
|
@PleasantD rebase? |
… ORDER clauses with queries or expressions
|
Done |
hazzik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HqlSqlWalker grammar was not supporting more than a single query in the ORDER clause.
It would handle multiple expressions because it was looking for them with a recursive lookup, but the parsing of a query was only being handled by the master ORDER clause.
So a single query would work, or any number of expression. But combine an expression with a query or multiple queries and it would fail.
I moved the query check into the inner part of the ORDER grammar so that it becomes part of the recursive parsing, like expressions.