NH-3726: Added escape character support in SqlMethods.Like #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hmm... I'm on a shaky rural connection, but will try to fix ASAP |
gliljas
force-pushed
the
NH-3726
branch
2 times, most recently
from
b7a58da to
f73001e
Compare
|
Fixed and squashed |
|
|
||
| //This entity will be flushed to the db, but rolled back when the test completes | ||
|
|
||
| session.Save(new Employee { FirstName = employeeName, LastName = "" }); |
There was a problem hiding this comment.
Oracle does not like "" as LastName because in Oracle "" is NULL
|
I suspect it's the choice of escape character that is causing the fail in MySql. I will test. |
|
I've fixed the issue on MySql, but decided to also rebase to get rid of unrelated formatting changes. Merged separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not yet follow my own suggestion to fix StartsWIth, Contains and EndWith, since that could be considered a breaking change. But it is a bug, IMO.