Test case and fix to NH-3898 #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this patch get merged, it would be probably more likely to happen on master or 4.1 branch. If you port your PR on master, now it requires VS2017 (Community edition is enough). The change looks legit, but you need to follow contributing guidelines. Notably, use tabs instead of spacing. |
hazzik
force-pushed
the
4.0.4.GA-NH-3898
branch
2 times, most recently
from
ed8051b to
e89e9db
Compare
hazzik
previously approved these changes
Nov 14, 2017
(https://nhibernate.jira.com/browse/NH-3898) Configuring a property with generated="insert" it makes "Property.IsUpdatable" "false" even using update="true" in the xml mapping file. Please consider keep this issue as Critical, as it does not break the application, it makes the applications migrated from NHibernate version 2 to 3 or 4 generates inconsistent data within the database. As soon as I can, I will send a pull request
…the property is not yet set to the actual inserted value db side.
fredericDelaporte
force-pushed
the
4.0.4.GA-NH-3898
branch
from
e89e9db to
056912b
Compare
|
Re-based for fixing the release build, small additional fix added to test. |
fredericDelaporte
previously approved these changes
Nov 16, 2017
hazzik
reviewed
Nov 16, 2017
| Assert.That(employee.PromotionCount, Is.EqualTo(0)); | ||
| employee.Name = "Employee 1 changed"; | ||
| employee.PromotionCount++; | ||
| Assert.That(employee.PromotionCount, Is.EqualTo(1)); |
There was a problem hiding this comment.
That assert does not make sense anymore.
hazzik
approved these changes
Nov 17, 2017
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case and fix to NH-3898
Configuring a property with generated="insert" it makes
"Property.IsUpdatable" "false" even using update="true" in the xml
mapping file.
Please consider keep this issue as Critical, as it does not break the
application, it makes the applications migrated from NHibernate version
2 to 3 or 4 generates inconsistent data within the database.