NH-3950: failure of FutureValue on First/Single result operator. Fix and test cases #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial commits has failed some Oracle 32 tests in teamcity. (Now I have rebase for cleaning up commit history, and I expect next TeamCity build to fail again.) (Edit: now I have seen the message on nhibernate development about troubles with DTC, causing those failures with Oracle 32, unrelated to pull request changes.) |
fredericDelaporte
force-pushed
the
NH-3950
branch
from
05259b5 to
96048a1
Compare
fredericDelaporte
changed the title
hazzik
approved these changes
Feb 28, 2017
|
Waiting tests to run. Then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases and fix for NH-3950: failure of FutureValue on First/Single result operator.
All test cases, using SQLServer, pass. (Excepted DtcFailuresFixture.Can_roll_back_transaction which fails to cleanup (connection closed: False) whatever I do, even without my changes.)
I consider this to be a prerequisite for NH-3850.
FuturValue.cs diff looks ugly due to previous indentation: it was using spaces instead of tabs, contrary to guidlines. Relevant changes are in
Valuegetter.