NH-3951 - support of .All as query result. Test cases, fix and refactoring #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
force-pushed
the
NH-3951
branch
from
a014f6a to
81e84ab
Compare
|
As for 555 pull, I do not understand how my changes may relate to the Oracle 32 failing cases. (Edit: now I have seen the message on nhibernate development about troubles with DTC, causing those failures with Oracle 32, unrelated to pull request changes.) |
fredericDelaporte
changed the title
fredericDelaporte
changed the title
fredericDelaporte
changed the title
| @@ -53,11 +61,6 @@ public IntermediateHqlTree(bool root) | |||
|
|
|||
| public ExpressionToHqlTranslationResults GetTranslation() | |||
| { | |||
| if (_isRoot) | |||
| { | |||
| DetectOuterExists(); | |||
There was a problem hiding this comment.
Now handled in ProcessAny result operator.
| tree.AddWhereClause(tree.TreeBuilder.BooleanNot( | ||
| HqlGeneratorExpressionTreeVisitor.Visit(resultOperator.Predicate, queryModelVisitor.VisitorParameters). | ||
| ToBooleanExpression())); | ||
| public class ProcessAll : IResultOperatorProcessor<AllResultOperator> |
There was a problem hiding this comment.
Was formatted with spaces, got formatted with tabs.
|
Looks legit |
fredericDelaporte
force-pushed
the
NH-3951
branch
from
e06627f to
5d3192e
Compare
fredericDelaporte
changed the title
…toring .Any as final result for avoiding HQL tree inspection.
fredericDelaporte
force-pushed
the
NH-3951
branch
from
5d3192e to
9a5f3c0
Compare
|
Rebased and squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements NH-3951.
This allows calls such as
session.Query<Entity>().All(e => someCondition)), instead of having to work-around with!session.Query<Entity>().Any(e => !someCondition)).Support of the
Anycase was using some "after-thought" tree inspection, I have simplified it by handling it in theProcessAnyresult operator processor. This has required exposing the_isRootmember ofIntermediateHqlTreethrough anIsRootgetter, in order to avoid compromising usages ofAny|Allas sub-queries.Of course, all test cases continue to pass. (Excepted the
DtcFailuresFixture.Can_roll_back_transactionwhich has an unrelatedTearDownissue (not closing its connection), which occurs on my setup without my changes too.)I would like to be able to go on fixing NH-3850 with changes done by this NH-3951.