Skip to content

NH-3956 - native SQL query plan cache fix. #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2017

Conversation

fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Mar 3, 2017

Fix and test cases for NH-3956: Native SQL query plan may get wrong plan.

Equals was relying on hashcode equality.

Code taken back prior to that "bad optimization", and compared to hibernate code base (main difference: NHibernate shortcuts on hashcode inequality, not Hibernate).

I have spotted some other discrepancies by the way, but left them untouched: Equals implementations for INativeSQLQueryReturn classes do only test their alias properties on NHibernate side, while Hibernate test all properties.

Test cases only test Equality, they do not showcase query plan cache failures which may result from those Equality failures, contrary to those of NH-3954 for the proxy cache. But there is no reason the query plan cache would not have been affected by those Equals failures.

@fredericDelaporte fredericDelaporte force-pushed the NH-3956 branch 4 times, most recently from dd366d4 to 9a36ef9 Compare March 6, 2017 15:08
@fredericDelaporte
Copy link
Member Author

I have re-based only for amending the commit message. It looks like a general failure on Team City side was affecting most tests: the builds triggered by this rebase now looks to be passing. (Already 3 good, while previous builds had them all failed but one.)

@fredericDelaporte
Copy link
Member Author

MySql failure is a timeout. To me, it looks like a test infrastructure frequent failure rather than a regression. The same trouble with the same test happened for PR, though it does not changes the same things at all.

@fredericDelaporte fredericDelaporte changed the title NH-3956: native SQL query plan cache fix. NH-3956 - native SQL query plan cache fix. Mar 18, 2017
@hazzik
Copy link
Member

hazzik commented Mar 26, 2017

@fredericDelaporte can you please rebase on top of master?

@fredericDelaporte fredericDelaporte force-pushed the NH-3956 branch 4 times, most recently from 49a8fbd to 08ec728 Compare March 26, 2017 11:24
@hazzik hazzik merged commit ee42371 into nhibernate:master Mar 26, 2017
@fredericDelaporte fredericDelaporte deleted the NH-3956 branch March 26, 2017 20:52
@fredericDelaporte fredericDelaporte added this to the 5.0.0 milestone Mar 26, 2017
@hazzik hazzik added the r: Fixed label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants