NH-3988 - Replace ApplicationException with Exception #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I had seen those usages of ApplicationException and I was knowing this is an obsolete practice. But well, it does not really harm as far as I know, so I had not proposed to change that. I am for it.
Now I would rather not throw the base Exception class instead on the cases where ApplicationExceptionwas throw. (I am ok with deriving from it of course, this is just the throwing which I dislike.)
src/NHibernate/Logging.cs
Outdated
| @@ -63,15 +63,15 @@ private static ILoggerFactory GetLoggerFactory(string nhibernateLoggerClass) | |||
| } | |||
| catch (MissingMethodException ex) | |||
| { | |||
| throw new ApplicationException("Public constructor was not found for " + loggerFactoryType, ex); | |||
| throw new Exception("Public constructor was not found for " + loggerFactoryType, ex); | |||
There was a problem hiding this comment.
I would rather throw an ArgumentException here (or InvalidOperationException). We should not throw the base Exception class.
src/NHibernate/Logging.cs
Outdated
| } | ||
| catch (InvalidCastException ex) | ||
| { | ||
| throw new ApplicationException(loggerFactoryType + "Type does not implement " + typeof (ILoggerFactory), ex); | ||
| throw new Exception(loggerFactoryType + "Type does not implement " + typeof (ILoggerFactory), ex); |
src/NHibernate/Logging.cs
Outdated
| } | ||
| catch (Exception ex) | ||
| { | ||
| throw new ApplicationException("Unable to instantiate: " + loggerFactoryType, ex); | ||
| throw new Exception("Unable to instantiate: " + loggerFactoryType, ex); |
|
Replaced bare |
fredericDelaporte
approved these changes
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.