NH-3037: ActionQueue Insertion sort performance degrades exponentially #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It whould be great if you provide a test case for this issue. |
|
Many of the existing testcases already perform effective functional tests for the change, so I added a few testcases to benchmark sorting different #s of insert actions. On my machine and the original implementation, the performance starts to noticeably slow down at around 10000 pending insert actions, taking approximately 1s to perform the sort. 40000 pending insert actions would take approximately 30s. With the implementation included in this fix, 10000 inserts takes 0.015s to sort and 40000 takes 0.025s. |
|
Thanks, applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less a line for line port of the improvements found in HHH-2957.