Skip to content

NH-4073 - Replace NHibernate.Web.Example with modern version. #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2017

Conversation

ngbrown
Copy link
Contributor

@ngbrown ngbrown commented Aug 16, 2017

This is NH-4073

@ngbrown ngbrown mentioned this pull request Aug 16, 2017
29 tasks
@hazzik
Copy link
Member

hazzik commented Aug 16, 2017

Some white spaces are inconsistent

@ngbrown
Copy link
Contributor Author

ngbrown commented Aug 16, 2017

@hazzik It's because the templates started out at 4 space characters tabs, but the .editorconfig dictates hard tabs for any new lines I create, and then GitHub shows tabs as 8 spaces.

Is the solution to convert every *.cs file to tabs then? Can I set *.cshtml and *.json to 2 character spaces in .editorconfig?

@hazzik
Copy link
Member

hazzik commented Aug 16, 2017

Yes, .editorconfig would work. I think the options shall be as following:
.xml: spaces, 2 spaces
.json: spaces, 2 spaces
.cshtml: spaces, 4 spaces

Same great 2006 look but with HTML5 instead of XHTML.  Razor .cshtml
files instead of .aspx.

Using Razor pages for simplicity and to achieve approximately the same
code feel as the previous ASP.NET Web Pages used.

ISession lifetime is controlled by dependency injection service
lifetimes instead of custom IHttpModule.
@ngbrown
Copy link
Contributor Author

ngbrown commented Aug 17, 2017

Fixed.

Evidently one can set the hard-tab width in GitHub by setting the indent_size in .editorconfig. isaacs/github#170 (comment) But then you wouldn't see when I screw it up. 😄

@hazzik hazzik merged commit df34f46 into nhibernate:master Aug 17, 2017
@hazzik hazzik added this to the 5.0 milestone Aug 17, 2017
@ngbrown ngbrown deleted the NH-4073 branch September 15, 2017 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants