NH-3114 - Collection inside Component cannot be mapped to a different table #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the first test verifies mapping-by-code generates a correct mapping, while the second test inserts an entity with the first component set but currently also gets the second component collection initialized with the same contents after retrieving this fixture is providing explicit column- and table-names to make sure everything ends up where we expect it.
since PropertyPath is used as dictionary key during mapping/customization, only considering the local part may lead to customizations being applied to the wrong members (or being applied multiple times, leaving only the last invocation each as effective result) with the parent path included, collection mappings on nested contexts (such as components) now work properly even when the nested context is repeated on the same type (such as having multiple properties of the same component type on a root or subclass)
fredericDelaporte
approved these changes
Sep 18, 2017
hazzik
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://nhibernate.jira.com/browse/NH-3114 (at least for the case described with explicit column- and table-names specified).
While discussing the issue, we noticed another thing that might happen with such kind of mappings while using implicit names derived from the classes/properties/etc. being used. But since that one appears to be a general issue (also happens with the base XML mappings, not just mapping-by-code) and potentially more complex to fix I decided to only handle the explicit case in here.
Note that I have the habit of doing "Format Document" plus "Remove and Sort usings" when changing/saving files, so
PropertyContainerCustomizer.cstook a dip there. I can drop the last commit if you want, though.