Skip to content

Back port doc fixes #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 12, 2017
Merged

Conversation

fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Oct 12, 2017

A bunch of fixes were done directly in html files of https://github.com/nhibernate/nhibernate.github.io, instead of being done in the documentation source files here.

I have ported back most of them. I have not ported some changes (like changing in prose ISet for ISet<T> since we can consider it implied) and adjusted slightly some others.

Some of those changes were already re-done in source here, sometime in another way: I have kept the way they were already redone. (Going generic, fixing usage of no more existent methods like ISession.Enumerable/Find, ...)

Most of those changes were done by @rjperes, and some by @hazzik.

- Mention of LINQ as a querying API;
- Example of Delete with a query string;
- Minor corrections
- Included <subselect>;
- Replaced load() and get() Java mentions for Load() and Get();
- Minor corrections.
- "be Serializable" -> "marked with the Serializable attribute";
- "seperator" -> "separator";
- Mentioned that NH now only supports generic collections.
- Updated list of interfaces that can be used in collection declarations;
- All collections made generic;
- Added reference to default_flush_mode;
- Added reference to query.linq_provider_class;
- Removed references to proxyfactory.factory_class;
- Fixed reference to MsSqlCe40Dialect;
- Removed reference to version 2.0 of NHibernate.Mapping.Attributes;
- Various minor corrections.
@hazzik hazzik merged commit e34d751 into nhibernate:master Oct 12, 2017
@hazzik hazzik added this to the 5.0.1 milestone Oct 12, 2017
@fredericDelaporte
Copy link
Member Author

Too fast! I have made a glitch causing the doc to fail generating. Going to fix that.

@hazzik
Copy link
Member

hazzik commented Oct 12, 2017

Ok 😢

@fredericDelaporte
Copy link
Member Author

I had already forced push it, but maybe one minute after your merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants