Utf8 Component #12

hhamon · 2017-02-24T14:29:42Z

No description provided.

fabpot · 2017-02-24T14:39:07Z

src/Symfony/Component/Utf8/Exception/InvalidArgumentException.php

+
+namespace Symfony\Component\Utf8\Exception;
+
+class InvalidArgumentException extends \InvalidArgumentException


You should create an ExceptionInterface that acts as a marker for all exceptions coming from this component as done by other components.

fabpot · 2017-02-24T14:39:40Z

src/Symfony/Component/Utf8/GenericStringInterface.php

+     *
+     * @return bool
+     */
+    public function endsWith(string $suffix): bool;


Is requiring PHP7 done on purpose?

fabpot · 2017-02-24T14:40:13Z

src/Symfony/Component/Utf8/String.md

@@ -0,0 +1,118 @@
+String Class APIs Comparison


Should probably be removed

nicolas-grekas · 2017-02-24T17:07:14Z

src/Symfony/Component/Utf8/CodePoints.php

+        }
+
+        if ('' === $this->string) {
+            yield clone $this;


just "return"? str_split return array('') with empty strings, but I don't get why this is useull at all.
WDYT? (same in the other "getIterator")

nicolas-grekas · 2017-03-23T07:56:40Z

src/Symfony/Component/Utf8/GenericStringInterface.php

+
+    public function length(): int;
+
+    public function width(): int;


we'll need an arg here, to allow for non-countoing for CLI decorations - could even be the default to me

like $strict = true?

nicolas-grekas · 2017-03-23T07:58:50Z

src/Symfony/Component/Utf8/GenericStringInterface.php

+    /**
+     * @return static
+     */
+    public function toUpperCase();


let's add another one: toFoldedCase, could be useful to me

nicolas-grekas · 2019-09-18T06:15:20Z

Continued in symfony#33553

…hen publishing a message. (jwage) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Messenger] [Amqp] Handle AMQPConnectionException when publishing a message. | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony#36538 Fix symfony#48241 | License | MIT If you have a message handler that dispatches messages to another queue, you can encounter `AMQPConnectionException` with the message "Library error: a SSL error occurred" or "a socket error occurred" depending on if you are using tls or not or if you are running behind a load balancer or not. You can manually reproduce this issue by dispatching a message where the handler then dispatches another message to a different queue, then go to rabbitmq admin and close the connection manually, then dispatch another message and when the message handler goes to dispatch the other message, you will get this exception: ``` a socket error occurred #0 /vagrant/vendor/symfony/amqp-messenger/Transport/AmqpTransport.php(60): Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpSender->send() #1 /vagrant/vendor/symfony/messenger/Middleware/SendMessageMiddleware.php(62): Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransport->send() #2 /vagrant/vendor/symfony/messenger/Middleware/FailedMessageProcessingMiddleware.php(34): Symfony\Component\Messenger\Middleware\SendMessageMiddleware->handle() #3 /vagrant/vendor/symfony/messenger/Middleware/DispatchAfterCurrentBusMiddleware.php(61): Symfony\Component\Messenger\Middleware\FailedMessageProcessingMiddleware->handle() #4 /vagrant/vendor/symfony/messenger/Middleware/RejectRedeliveredMessageMiddleware.php(41): Symfony\Component\Messenger\Middleware\DispatchAfterCurrentBusMiddleware->handle() #5 /vagrant/vendor/symfony/messenger/Middleware/AddBusNameStampMiddleware.php(37): Symfony\Component\Messenger\Middleware\RejectRedeliveredMessageMiddleware->handle() #6 /vagrant/vendor/symfony/messenger/Middleware/TraceableMiddleware.php(40): Symfony\Component\Messenger\Middleware\AddBusNameStampMiddleware->handle() #7 /vagrant/vendor/symfony/messenger/MessageBus.php(70): Symfony\Component\Messenger\Middleware\TraceableMiddleware->handle() #8 /vagrant/vendor/symfony/messenger/TraceableMessageBus.php(38): Symfony\Component\Messenger\MessageBus->dispatch() #9 /vagrant/src/Messenger/MessageBus.php(37): Symfony\Component\Messenger\TraceableMessageBus->dispatch() #10 /vagrant/vendor/symfony/mailer/Mailer.php(66): App\Messenger\MessageBus->dispatch() #11 /vagrant/src/Mailer/Mailer.php(83): Symfony\Component\Mailer\Mailer->send() #12 /vagrant/src/Mailer/Mailer.php(96): App\Mailer\Mailer->send() #13 /vagrant/src/MessageHandler/Trading/StrategySubscriptionMessageHandler.php(118): App\Mailer\Mailer->sendEmail() #14 /vagrant/src/MessageHandler/Trading/StrategySubscriptionMessageHandler.php(72): App\MessageHandler\Trading\StrategySubscriptionMessageHandler->handle() #15 /vagrant/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php(152): App\MessageHandler\Trading\StrategySubscriptionMessageHandler->__invoke() #16 /vagrant/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php(91): Symfony\Component\Messenger\Middleware\HandleMessageMiddleware->callHandler() #17 /vagrant/vendor/symfony/messenger/Middleware/SendMessageMiddleware.php(71): Symfony\Component\Messenger\Middleware\HandleMessageMiddleware->handle() #18 /vagrant/vendor/symfony/messenger/Middleware/FailedMessageProcessingMiddleware.php(34): Symfony\Component\Messenger\Middleware\SendMessageMiddleware->handle() #19 /vagrant/vendor/symfony/messenger/Middleware/DispatchAfterCurrentBusMiddleware.php(68): Symfony\Component\Messenger\Middleware\FailedMessageProcessingMiddleware->handle() #20 /vagrant/vendor/symfony/messenger/Middleware/RejectRedeliveredMessageMiddleware.php(41): Symfony\Component\Messenger\Middleware\DispatchAfterCurrentBusMiddleware->handle() #21 /vagrant/vendor/symfony/messenger/Middleware/AddBusNameStampMiddleware.php(37): Symfony\Component\Messenger\Middleware\RejectRedeliveredMessageMiddleware->handle() #22 /vagrant/vendor/symfony/messenger/Middleware/TraceableMiddleware.php(40): Symfony\Component\Messenger\Middleware\AddBusNameStampMiddleware->handle() #23 /vagrant/vendor/symfony/messenger/MessageBus.php(70): Symfony\Component\Messenger\Middleware\TraceableMiddleware->handle() #24 /vagrant/vendor/symfony/messenger/TraceableMessageBus.php(38): Symfony\Component\Messenger\MessageBus->dispatch() #25 /vagrant/vendor/symfony/messenger/RoutableMessageBus.php(54): Symfony\Component\Messenger\TraceableMessageBus->dispatch() #26 /vagrant/vendor/symfony/messenger/Worker.php(162): Symfony\Component\Messenger\RoutableMessageBus->dispatch() #27 /vagrant/vendor/symfony/messenger/Worker.php(109): Symfony\Component\Messenger\Worker->handleMessage() #28 /vagrant/vendor/symfony/messenger/Command/ConsumeMessagesCommand.php(238): Symfony\Component\Messenger\Worker->run() #29 /vagrant/vendor/symfony/console/Command/Command.php(326): Symfony\Component\Messenger\Command\ConsumeMessagesCommand->execute() #30 /vagrant/vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run() #31 /vagrant/vendor/symfony/framework-bundle/Console/Application.php(126): Symfony\Component\Console\Application->doRunCommand() #32 /vagrant/vendor/symfony/console/Application.php(324): Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() #33 /vagrant/vendor/symfony/framework-bundle/Console/Application.php(80): Symfony\Component\Console\Application->doRun() #34 /vagrant/vendor/symfony/console/Application.php(175): Symfony\Bundle\FrameworkBundle\Console\Application->doRun() #35 /vagrant/vendor/symfony/runtime/Runner/Symfony/ConsoleApplicationRunner.php(49): Symfony\Component\Console\Application->run() #36 /vagrant/vendor/autoload_runtime.php(29): Symfony\Component\Runtime\Runner\Symfony\ConsoleApplicationRunner->run() #37 /vagrant/bin/console(11): require_once('...') #38 {main} ``` TODO: - [x] Add test for retry logic when publishing messages Commits ------- f123370 [Messenger] [Amqp] Handle AMQPConnectionException when publishing a message.

…nal::readFromProcess` (fritzmg) This PR was merged into the 5.4 branch. Discussion ---------- [Console] Suppress `proc_open` errors within `Terminal::readFromProcess` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT When instantiating `SymfonyStyle` in a command it will try to determine the maximum width of the current console interface. https://github.com/symfony/symfony/blob/6687e4ea35f45ebd73fb0315938103628cfb13a0/src/Symfony/Component/Console/Style/SymfonyStyle.php#L53 This will execute `stty -a | grep columns` down the line. Access to `stty` might be disallowed however, resulting in the following error: ``` ErrorException: Warning: proc_open(): Exec failed: Permission denied #16 /vendor/symfony/console/Terminal.php(220): Symfony\Component\Console\Terminal::readFromProcess #15 /vendor/symfony/console/Terminal.php(204): Symfony\Component\Console\Terminal::getSttyColumns #14 /vendor/symfony/console/Terminal.php(170): Symfony\Component\Console\Terminal::initDimensionsUsingStty #13 /vendor/symfony/console/Terminal.php(153): Symfony\Component\Console\Terminal::initDimensions #12 /vendor/symfony/console/Terminal.php(94): Symfony\Component\Console\Terminal::getWidth #11 /vendor/symfony/console/Style/SymfonyStyle.php(55): Symfony\Component\Console\Style\SymfonyStyle::__construct #10 /vendor/symfony/messenger/Command/ConsumeMessagesCommand.php(136): Symfony\Component\Messenger\Command\ConsumeMessagesCommand::interact #9 /vendor/symfony/console/Command/Command.php(311): Symfony\Component\Console\Command\Command::run ``` (Stack Trace actually from Symfony 6) The phpDoc of `Terminal::getSttyColumns` states > Runs and parses stty -a if it's available, _suppressing any error output_. The latter might refer to `['suppress_errors' => true]` (though I am not sure) - which is a Windows only functionality. In any case, since `Terminal::readFromProcess` already checks for ```php if (!$process = proc_open(…)) { return null; } ``` and ```php if (!\is_resource($process)) { return null; } ``` upstream in Symfony 6/7, indicating that `proc_open` might fail - this error can additionally be suppressed using `@`. Besides, `Process::start` also uses ``@proc_open`` (added in symfony@099481f "Prevent warning in proc_open()"). Commits ------- 575249a suppress proc_open errors

hhamon force-pushed the utf8 branch from 22f4318 to 206af19 Compare February 24, 2017 14:30

fabpot reviewed Feb 24, 2017

View reviewed changes

hhamon force-pushed the utf8 branch 5 times, most recently from 3fd0313 to c9d6417 Compare February 24, 2017 17:03

nicolas-grekas reviewed Feb 24, 2017

View reviewed changes

hhamon force-pushed the utf8 branch 7 times, most recently from 704368c to aeb40a6 Compare February 28, 2017 14:54

hhamon force-pushed the utf8 branch 8 times, most recently from d77f1da to 8833333 Compare March 20, 2017 09:24

hhamon force-pushed the utf8 branch 3 times, most recently from 6896c6d to 4ff9653 Compare March 22, 2017 19:20

nicolas-grekas reviewed Mar 23, 2017

View reviewed changes

hhamon force-pushed the utf8 branch 13 times, most recently from 9a12070 to 679106f Compare April 3, 2017 07:03

nicolas-grekas and others added 2 commits December 12, 2017 21:42

[Utf8] Create the component

cc1b8bc

[Utf8] added Bytes, CodePoints and Graphemes implementations

8be629d

hhamon force-pushed the utf8 branch from 679106f to 8be629d Compare December 12, 2017 20:44

hhamon added 3 commits December 12, 2017 22:03

Add PHP 7.1 support

572fbc9

Fixes CS

493509d

Drop HHVM support

6bc725a

nicolas-grekas force-pushed the master branch 7 times, most recently from 39e5b16 to 226e2f3 Compare May 10, 2018 18:52

nicolas-grekas closed this Sep 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Utf8 Component #12

Utf8 Component #12

Uh oh!

hhamon commented Feb 24, 2017

Uh oh!

fabpot Feb 24, 2017

Uh oh!

hhamon Feb 24, 2017

Uh oh!

fabpot Feb 24, 2017

Uh oh!

fabpot Feb 24, 2017

Uh oh!

hhamon Feb 24, 2017

Uh oh!

nicolas-grekas Feb 24, 2017

Uh oh!

nicolas-grekas Mar 23, 2017

Uh oh!

hhamon Mar 23, 2017

Uh oh!

nicolas-grekas Mar 23, 2017

Uh oh!

nicolas-grekas commented Sep 18, 2019

Uh oh!

Uh oh!


		namespace Symfony\Component\Utf8\Exception;

		class InvalidArgumentException extends \InvalidArgumentException

Utf8 Component #12

Utf8 Component #12

Uh oh!

Conversation

hhamon commented Feb 24, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Sep 18, 2019

Uh oh!

Uh oh!