[ENH] Add new dipy interfaces #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is another PR to be reviewed by dipy's crew (@arokem, @Garyfallidis, etc) |
|
@satra, @chrisfilo How could I check that dipy has certain version, and make the interfaces unavailable if too old? |
Conflicts: CHANGES
|
It would be great to add this, but there are still some tests failing. |
|
hey @chrisfilo , yep, the problem is on checking the dipy version. My problem here is two-fold: 1) I don't know exactly what is the policy we want to set on dipy versions, since it is developing very (very) fast; and 2) I would need to check how you do this in other interfaces where version is important. |
|
@satra @chrisfilo , tests are passing (circle hook didn't update, but passed), how do you see this? |
chrisgorgo
added a commit
that referenced
this pull request
Feb 13, 2016
[ENH] Add new dipy interfaces
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added interfaces to RESTORE, response estimator and CSD in reconstructions. Added StreamlineTractography in tracks.py.