Skip to content

Make CircleCI use all 4 containers #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2017
Merged

Make CircleCI use all 4 containers #1769

merged 1 commit into from
Jan 12, 2017

Conversation

conormcd
Copy link
Contributor

  • Cache both docker containers.
  • Split the tests across all 4 containers.

@conormcd
Make CircleCI use all 4 containers
a9e2470 
- Cache both docker containers.
- Split the tests across all 4 containers.
@chrisgorgo
Copy link
Member

So far we have been using spare containers to run tests on PRs. What's the speed improvement when switching to using 4 containers (when counting on test time)?

@conormcd
Copy link
Contributor Author

The tests are currently set to 4x parallelism so three out of the four containers are idle and unusable for every build. This PR brings the time for a test run from 3.5-4 hours down to 1.5-2 hours. So, approximately a 2 hour saving per build.

https://circleci.com/gh/conormcd/nipype/8 and https://circleci.com/gh/conormcd/nipype/9 are example builds with this change.

@chrisgorgo
Copy link
Member

Ah yes - you are right.

@chrisgorgo chrisgorgo merged commit f11a457 into nipy:master Jan 12, 2017
@mgxd mgxd mentioned this pull request Jan 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conormcd @chrisgorgo