Skip to content

ENH: Enable new BBRegister init options for FSv6+ #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

effigies
Copy link
Member

bbregister has new initialization options, including an implicit default of using mri_coreg, as of version 6.0.0.

This change updates the init trait if FreeSurfer is version 6 or newer, following the example from FSL.

Is there a good way to test this?

@chrisgorgo
Copy link
Member

The PR looks good, but it's missing those silly auto_ tests. Could make specs?

@effigies
Copy link
Member Author

Doesn't seem to result in any changes to auto_ tests.

@chrisgorgo
Copy link
Member

I guess it's not picking up the freesurfer as version 6. It should be fine to keep it as it is.

@codecov-io
Copy link

Codecov Report

Merging #1811 into master will decrease coverage by -0.01%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
- Coverage   69.82%   69.82%   -0.01%     
==========================================
  Files        1047     1047              
  Lines       52133    52137       +4     
  Branches     7669     7670       +1     
==========================================
+ Hits        36403    36405       +2     
- Misses      14142    14150       +8     
+ Partials     1588     1582       -6
Flag Coverage Δ
#unittests 69.82% <60%> (-0.01%)
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/preprocess.py 64.26% <60%> (-0.07%)
nipype/interfaces/io.py 57.55% <ø> (ø)
nipype/interfaces/nipy/preprocess.py 47.56% <ø> (ø)
nipype/interfaces/dynamic_slicer.py 17.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ed4d6...514f5b5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants