Skip to content

update tests to py36, clean up documentation towards release #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 29, 2017
Merged

update tests to py36, clean up documentation towards release #1977

merged 7 commits into from
Apr 29, 2017

Conversation

satra
Copy link
Member

@satra satra commented Apr 28, 2017

No description provided.

oesteban
oesteban reviewed Apr 28, 2017
View reviewed changes
nipype/info.py
@@ -94,16 +95,16 @@ def get_nipype_gitversion():
"""

# versions
NIBABEL_MIN_VERSION = '2.0.1'
NIBABEL_MIN_VERSION = '2.1.0'
NETWORKX_MIN_VERSION = '1.7'
NUMPY_MIN_VERSION = '1.6.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably raise to numpy>=1.11, I think the mmap issue was solved with that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we support the mmap issue, perhaps we can change this after the release.

@oesteban
Copy link
Contributor

@satra I'm updating the nipype/base image to add g++. With that one installed, the new image should build correctly. Will send a modification to your PR when I check everything is ok (within a couple of hours).

@codecov-io
Copy link

codecov-io commented Apr 29, 2017 •
edited
Loading

Codecov Report

Merging #1977 into master will decrease coverage by 0.02%.
The diff coverage is 26.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1977      +/-   ##
==========================================
- Coverage    72.6%   72.57%   -0.03%     
==========================================
  Files        1070     1070              
  Lines       54454    54458       +4     
  Branches     7868     7869       +1     
==========================================
- Hits        39535    39523      -12     
- Misses      13686    13702      +16     
  Partials     1233     1233
Flag Coverage Δ
#smoketests 72.57% <26.19%> (-0.03%) ⬇️
#unittests 70.13% <26.19%> (-0.03%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/engine/tests/test_engine.py 93.54% <100%> (ø) ⬆️
nipype/info.py 83.6% <100%> (ø) ⬆️
nipype/sphinxext/plot_workflow.py 13.29% <26.31%> (+0.16%) ⬆️
nipype/pipeline/engine/utils.py 78.69% <5.55%> (-1.58%) ⬇️
nipype/interfaces/fsl/tests/test_auto_TOPUP.py 85.71% <0%> (ø) ⬆️
nipype/interfaces/fsl/epi.py 66.15% <0%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca30015...8331445. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Apr 29, 2017 •
edited
Loading

Codecov Report

Merging #1977 into master will decrease coverage by 0.02%.
The diff coverage is 26.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1977      +/-   ##
==========================================
- Coverage    72.6%   72.57%   -0.03%     
==========================================
  Files        1070     1070              
  Lines       54454    54458       +4     
  Branches     7868     7869       +1     
==========================================
- Hits        39535    39523      -12     
- Misses      13686    13702      +16     
  Partials     1233     1233
Flag Coverage Δ
#smoketests 72.57% <26.19%> (-0.03%) ⬇️
#unittests 70.13% <26.19%> (-0.03%) ⬇️
Impacted Files Coverage Δ
nipype/info.py 83.6% <100%> (ø) ⬆️
nipype/pipeline/engine/tests/test_engine.py 93.54% <100%> (ø) ⬆️
nipype/sphinxext/plot_workflow.py 13.29% <26.31%> (+0.16%) ⬆️
nipype/pipeline/engine/utils.py 78.69% <5.55%> (-1.58%) ⬇️
nipype/interfaces/fsl/tests/test_auto_TOPUP.py 85.71% <0%> (ø) ⬆️
nipype/interfaces/fsl/epi.py 66.15% <0%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca30015...8331445. Read the comment docs.

@satra satra merged commit 91354f8 into nipy:master Apr 29, 2017
@satra satra mentioned this pull request Apr 29, 2017
Merged
@satra satra deleted the fix/py36 branch October 30, 2017 15:16
@effigies effigies mentioned this pull request Jan 5, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban oesteban left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satra @oesteban @codecov-io