Skip to content

Minor cleanups #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2018
Merged

Minor cleanups #2519

merged 2 commits into from
Mar 30, 2018

Conversation

effigies
Copy link
Member

Running make check-before-commit prompted the following cleanups.

Changes proposed in this pull request

  • Renames test_dcm2nii.py to test_extra_dcm2nii.py, as OSX's case insensitivity causes make specs to remove test_auto_Dcm2nii.py. Issue introduced in Fix/dcm2niix #2498.
  • Whitespace cleanups.

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #2519 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2519      +/-   ##
==========================================
+ Coverage   66.84%   66.88%   +0.04%     
==========================================
  Files         327      327              
  Lines       42479    42479              
  Branches     5268     5268              
==========================================
+ Hits        28393    28411      +18     
+ Misses      13381    13366      -15     
+ Partials      705      702       -3
Flag Coverage Δ
#smoketests 50.83% <ø> (+0.3%) ⬆️
#unittests 64.23% <ø> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/afni/preprocess.py 81.03% <ø> (ø) ⬆️
nipype/pipeline/engine/nodes.py 83.91% <0%> (+0.33%) ⬆️
nipype/utils/provenance.py 84.71% <0%> (+1.27%) ⬆️
nipype/workflows/fmri/spm/preprocess.py 72.44% <0%> (+12.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3ea2d...15274fb. Read the comment docs.

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgxd mgxd merged commit 539930e into nipy:master Mar 30, 2018
@effigies effigies deleted the cleanup branch March 30, 2018 17:19
@effigies effigies added this to the 1.0.3 milestone Apr 1, 2018
@effigies effigies mentioned this pull request Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants