Skip to content

FIX: Print UID in crashfile if login name is unavailable #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2018

Conversation

effigies
Copy link
Member

Related: nipreps/fmriprep#1060

Changes proposed in this pull request

  • Use a stand-in login name of UID<UID> if getpass.getuser() fails.

We had a user use the -u flag for Docker, which allowed them to run fMRIPrep and get outputs owned by their local user. If that UID doesn't exist for a user within the container, getpass.getuser() fails, and crashfiles cannot be written properly.

@effigies effigies added this to the 1.0.4 milestone Apr 30, 2018
@satra
Copy link
Member

satra commented Apr 30, 2018

lgtm

@effigies
Copy link
Member Author

DARTEL was timing out again, so I killed it. Can rebase this to re-run if needed.

@effigies effigies force-pushed the fix/crashfile_uid branch from 77aa9a1 to 65bb2c1 Compare May 1, 2018 03:13
@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #2563 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2563      +/-   ##
==========================================
- Coverage   67.13%   67.11%   -0.03%     
==========================================
  Files         333      333              
  Lines       42539    42542       +3     
  Branches     5265     5265              
==========================================
- Hits        28559    28551       -8     
- Misses      13278    13284       +6     
- Partials      702      707       +5
Flag Coverage Δ
#smoketests 50.36% <0%> (-0.35%) ⬇️
#unittests 64.47% <50%> (-0.05%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/plugins/tools.py 84.93% <50%> (-2.22%) ⬇️
nipype/info.py 80.59% <0%> (-4.48%) ⬇️
nipype/workflows/fmri/spm/preprocess.py 70.4% <0%> (-2.05%) ⬇️
nipype/utils/provenance.py 83.43% <0%> (-1.28%) ⬇️
nipype/pipeline/engine/nodes.py 83.96% <0%> (-0.34%) ⬇️
nipype/utils/profiler.py 44.25% <0%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4272c75...65bb2c1. Read the comment docs.

@effigies effigies merged commit fda8fa1 into nipy:master May 1, 2018
@effigies effigies deleted the fix/crashfile_uid branch May 18, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants