-
Notifications
You must be signed in to change notification settings - Fork 532
[WIP] adding mapping and submitter to enh/workflow syntax #2638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anging State.state_value so it returns values (and not arrays)
… SubmitterWorkflow class; simple test for NewNode.run using SubmitterNode
… had to create a new class and have now NewNodeBase and NewNode that is a wrapper with the run method
Codecov Report
@@ Coverage Diff @@
## master #2638 +/- ##
==========================================
- Coverage 67.6% 64.09% -3.51%
==========================================
Files 340 343 +3
Lines 43003 43479 +476
Branches 5321 5448 +127
==========================================
- Hits 29073 27869 -1204
- Misses 13231 14530 +1299
- Partials 699 1080 +381
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started adding my mapping and submitter to #2629. I didn't know how to merge
NewNode
with my submitter without creating an extra classNewNodeBase
and treatingNewNode
as a wrapper that runs nodes's interface.For now, I only added things related
mapper
, ignoredjoin
andjoindByKey
. Would like to get feedback first.I will be adding more tests (to shows mapping), working on
NewWorkflow
class.