ENH: Lightweight node cache checking #3026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satra
reviewed
Sep 11, 2019
effigies
reviewed
Sep 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #3026 +/- ##
==========================================
- Coverage 67.51% 64.18% -3.34%
==========================================
Files 344 342 -2
Lines 44045 43991 -54
Branches 5550 5547 -3
==========================================
- Hits 29739 28237 -1502
- Misses 13567 14628 +1061
- Partials 739 1126 +387
Continue to review full report at Codecov.
|
Generating the hashvalue when outputs are not ready at cache check stage when the node's directory does not exist (or no results file is in there) leads to nipy#3014. This PR preempts those problems by delaying the hashval calculation.
Co-Authored-By: Chris Markiewicz <[email protected]>
effigies
approved these changes
Sep 11, 2019
|
Travis seems a bit under the weather today. I'll go ahead and merge, making sure master passes all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating the hashvalue when outputs are not ready at cache check stage
when the node's directory does not exist (or no results file is in
there) leads to #3014.
This PR preempts those problems by delaying the hashval calculation.
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment