Skip to content

DBG: EulerNumber inconsistencies #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

DBG: EulerNumber inconsistencies #3185

wants to merge 3 commits into from

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Mar 9, 2020

EulerNumber test

def test_eulernumber(tmpdir):
# grab a surface from fsaverage
fssrc = FreeSurferSource(
subjects_dir=fs.Info.subjectsdir(), subject_id="fsaverage", hemi="lh"
)
pial = fssrc.run().outputs.pial
assert isinstance(pial, str), "Problem when fetching surface file"
eu = fs.EulerNumber()
eu.inputs.in_file = pial
res = eu.run()
assert res.outputs.defects == 0
assert res.outputs.euler == 2
is sporadically failing, see https://circleci.com/gh/nipy/nipype/11493

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #3185 into master will decrease coverage by 0.73%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3185      +/-   ##
==========================================
- Coverage   64.95%   64.22%   -0.74%     
==========================================
  Files         299      299              
  Lines       39506    39505       -1     
  Branches     5219     5220       +1     
==========================================
- Hits        25663    25373     -290     
- Misses      12784    13081     +297     
+ Partials     1059     1051       -8     
Flag Coverage Δ
#unittests 64.22% <0.00%> (-0.74%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/utils.py 60.34% <0.00%> (-2.91%) ⬇️
nipype/interfaces/nilearn.py 38.98% <0.00%> (-57.63%) ⬇️
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/interfaces/freesurfer/base.py 45.68% <0.00%> (-30.18%) ⬇️
nipype/utils/logger.py 58.46% <0.00%> (-27.70%) ⬇️
nipype/testing/fixtures.py 76.38% <0.00%> (-22.23%) ⬇️
nipype/interfaces/matlab.py 63.91% <0.00%> (-12.38%) ⬇️
nipype/interfaces/spm/base.py 57.66% <0.00%> (-9.67%) ⬇️
nipype/pkg_info.py 75.00% <0.00%> (-6.25%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347311c...7fb95b9. Read the comment docs.

@effigies
Copy link
Member

effigies commented Mar 9, 2020

Just bumping the build because I can't do it on Circle.

@effigies
Copy link
Member

Seeing this locally.

(Pdb) runtime.stdout
''
(Pdb) runtime.stderr
''
(Pdb) runtime.merged
'euler # = v-e+f = 2g-2: 163842 - 491520 + 327680 = 2 --> 0 holes\n      F =2V-4:          327680 = 327684-4 (0)\n      2E=3F:            983040 = 983040 (0)\n\ntotal defect index = 0'

@mgxd mgxd deleted the dbg/euler branch April 22, 2020 18:05
@effigies effigies modified the milestone: 1.5.0 May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants