-
Notifications
You must be signed in to change notification settings - Fork 533
ENH: Add inputs to mrtrix3.DWIPreprocInputSpec and remove mandatory annotation for pe_dir #3470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3470 +/- ##
=======================================
Coverage 65.25% 65.25%
=======================================
Files 309 309
Lines 40855 40858 +3
Branches 5379 5379
=======================================
+ Hits 26659 26662 +3
Misses 13122 13122
Partials 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conventionally, we only use mandatory=True
, as mandatory=False
is equivalent to not providing it at all. I will commit these changes. @GalBenZvi can you merge master afterwards?
Sure, no problem. (: |
Summary
Simply removed the "mandatory" tag from pe_dir keyword argument as it isn't really mandatory, for example when using rpe_header (in which dwifslpreproc will read the pe_dir from the associated metadata)
Fixes #3469 .