Don't call subprocess.Popen twice when output == 'file'. #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the real issue behind nipy#705
|
@carlohamalainen - thank you that was so silly! could you please rebase this on current master? |
|
Why isn't there a facepalm emoji |
|
OK, I've done 'git rebase upstream/master' and merged and committed and pushed, hopefully this sorts it out. |
satra
added a commit
that referenced
this pull request
Feb 8, 2014
Don't call subprocess.Popen twice when output == 'file'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the real issue behind #705 namely that when output == 'file', the code called subprocess.Popen twice, which forks two process.