Bind-mount /run/opengl-driver/lib for CUDA/OpenGL support #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-burns
force-pushed
the
opengl-driver-link
branch
from
60e4ee3 to
ed56961
Compare
|
Looks good. I try to test this soon but please ping me again in case I forget it. |
* check files/links before mounting and ignore if the mountpoint already exists * if the mountpoint of a directory exists and isn't a dir, we can't recurse and mount the subdir siblings
|
Must admit I'm not a big fan of the additional branchiness. Hopefully the value of the feature exceeds the cost of the added complexity. |
|
Friendly ping :) I've been using this for a while and haven't encountered any issues. Functionally I'm happy with it, but I'm not very experienced in Rust, so I'd appreciate any suggestions for making the code more idiomatic. |
|
Thanks! Tested in a container. |
|
Released in 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
This is implemented by allowing manual bind-mounts before the toplevel dirs are mounted. The bind mounting logic is now recursive, to allow for mounting siblings of any such previously mounted paths.
Currently, this functionality only exists to provide the user-owned /run/opengl-driver/lib bind mount alongside the host system's /run contents. However, it may be used for masking other paths in the future. For example, we could bind mount /nix/etc/nix/nix.conf to /etc/nix/nix.conf and do away with the need for the NIX_CONF_DIR override.