Replace most instances of mem::uninitialized with mem::MaybeUninit #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
force-pushed
the
maybe_uninit
branch
from
bd857cc to
567f36b
Compare
|
@Susurrus this is starting to hold up other PRs, so I'm going to merge it tonight. |
Only two instances remain: * For the deprecated sys::socket::CmsgSpace::new. We should probably just remove that method. * For sys::termios::Termios::default_uninit. This will require some more thought. Fixes nix-rust#1096
Travis's "stable" images are stuck on Rust 1.35.0
On Travis (and only on Travis) this test crashes. It hits an internal assertion within glibc. It happens reliably with rustc 1.37.0. Ignore the test until Travis updates its images; then we'll try again. Issue nix-rust#1099
asomers
force-pushed
the
maybe_uninit
branch
from
567f36b to
43a71ff
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 4, 2019
1114: Replace most instances of mem::uninitialized with mem::MaybeUninit r=asomers a=asomers Only two instances remain: * For the deprecated sys::socket::CmsgSpace::new. We should probably just remove that method. * For sys::termios::Termios::default_uninit. This will require some more thought. Co-authored-by: Alan Somers <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only two instances remain:
For the deprecated sys::socket::CmsgSpace::new. We should probably
just remove that method.
For sys::termios::Termios::default_uninit. This will require some
more thought.