sys: termios: Fix inverted logic for [cfg()] conditional for sparc64 #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for nix-rust#1149 has the logic for the [cfg()] conditional inverted so that the aliases for VMIN and VTIME are defined on targets that are not linux-sparc64.
|
Before merging this, please let me have another test run. I need to verify again that the fix works properly. |
glaubitz
force-pushed
the
sparc64-linux
branch
from
7c7993b to
992e5b1
Compare
|
Okay, this works now and rustyline builds fine on sparc64. |
bors bot
added a commit
that referenced
this pull request
Nov 2, 2019
1151: sys: termios: Fix inverted logic for [cfg()] conditional for sparc64 r=asomers a=glaubitz The fix for #1149 has the logic for the [cfg()] conditional inverted so that the aliases for VMIN and VTIME are defined on targets that are not linux-sparc64. Co-authored-by: John Paul Adrian Glaubitz <[email protected]>
Build failed |
|
You need to rebase to fix the build failure on nightly. |
glaubitz
force-pushed
the
sparc64-linux
branch
from
992e5b1 to
c7c1beb
Compare
|
Thanks. I have done that now. Also, simplified the code a bit more. |
bors bot
added a commit
that referenced
this pull request
Nov 2, 2019
1151: sys: termios: Fix inverted logic for [cfg()] conditional for sparc64 r=asomers a=glaubitz The fix for #1149 has the logic for the [cfg()] conditional inverted so that the aliases for VMIN and VTIME are defined on targets that are not linux-sparc64. Co-authored-by: John Paul Adrian Glaubitz <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for #1149 has the logic for the [cfg()] conditional inverted
so that the aliases for VMIN and VTIME are defined on targets that
are not linux-sparc64.