Skip to content

Fix nightly clippy in tests #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2022
Merged

Fix nightly clippy in tests #1722

merged 1 commit into from
May 16, 2022

Conversation

rtzoeller
Copy link
Collaborator

cargo +nightly clippy --tests currently produces

warning: this let-binding has unit value
   --> test/sys/test_uio.rs:256:20
    |
256 |             loop { let _ = pause(); }
    |                    ^^^^^^^^^^^^^^^^ help: omit the `let` binding: `pause();`
    |
    = note: `#[warn(clippy::let_unit_value)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

asomers
asomers approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented May 16, 2022

Build succeeded:

@bors bors bot merged commit b0ab557 into nix-rust:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtzoeller @asomers