SockProtocol::Raw = libc::IPPROTO_RAW for raw sockets #1848
Conversation
|
@posborne @kamalmarhubi @asomers can anyone review this please? I think it's easy to merge |
|
LGTM, but for a CHANGELOG entry. BTW, is SendIP something like Python's Scapy? I was using that this weekend. |
|
@asomers added it to the changelog. I don't know what scapy is, but in rust we can get the fastest packet generation compared to the python library. BTW, how often do you have releases, if PR would be merged? Update: Hmm, CI looks failed. Idk why but it isn't my problem |
|
@posborne @kamalmarhubi @asomers I'm sorry for the ping, but could you review this PR? Hope it's ready to be merged now |
CHANGELOG.md
Outdated
| @@ -26,6 +26,8 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |||
| ([#1841](https://github.com/nix-rust/nix/pull/1841)) | |||
| - Added `eaccess()` on FreeBSD, DragonFly and Linux (glibc and musl). | |||
| ([#1842](https://github.com/nix-rust/nix/pull/1842)) | |||
| - Added `SockProtocol::Raw = libc::IPPROTO_RAW` for raw sockets | |||
There was a problem hiding this comment.
| - Added `SockProtocol::Raw = libc::IPPROTO_RAW` for raw sockets | |
| - Added `SockProtocol::Raw` for raw sockets |
There was a problem hiding this comment.
@asomers I did some errors with rebase, but now looks likes CI is fine. Also merge conflict is now resolved
Hey, I wanna to make call like
socket(af_type, SOCK_RAW, IPPROTO_RAW)but currently there is no way to do it with rusthttps://github.com/rickettm/SendIP/blob/aad12a001157489ab9053c8665e09aec24a2ff6d/sendip.c#L143
Update: Feel free to add
#[cfg]attribute if I made mistakes that might cause errors on some platforms