Add docs to the time and fcntl modules #2289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
force-pushed
the
time-fcntl-docs
branch
from
8731404 to
adb1787
Compare
Also, deprecate FlockArg::UnlockNonblock. That combination of flags doesn't make sense. And indeed, reviewing the kernel source code shows that the kernel will ignore LOCK_NB when LOCK_UN is set.
asomers
force-pushed
the
time-fcntl-docs
branch
from
adb1787 to
b3633b5
Compare
SteveLauC
requested changes
Jan 15, 2024
| LockExclusive, | ||
| /// Unlock file | ||
| Unlock, |
There was a problem hiding this comment.
Maybe we can also deprecate the Unlock variant given that this FlockArg type is only used with the lock interface: Flock::lock()
SteveLauC
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, deprecate FlockArg::UnlockNonblock. That combination of flags doesn't make sense. And indeed, reviewing the kernel source code shows that the kernel will ignore LOCK_NB when LOCK_UN is set.