-
Notifications
You must be signed in to change notification settings - Fork 696
linux: Add sendfile(2) #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @arcnmx |
hrm |
Oh, r? is part of rust-highfive I think. |
r+ |
@homu r+ |
📌 Commit 191c506 has been approved by |
@homu r- |
woo it works |
@arcnmx would you mind taking a look? :-) |
Where's test_sendfile? o: |
oh dear rebase fail |
191c506
to
61b1d2a
Compare
@arcnmx fixed |
61b1d2a
to
4680d50
Compare
Pretty straightforward, looks good! My only comment is that the test would deadlock on a system without buffered pipes, but that's not the case on Linux so..! @homu r+ |
📌 Commit 4680d50 has been approved by |
⚡ Test exempted - status |
Fancy, it used an older test result o: |
Cool! @arcnmx out of curiosity, what common systems don't have buffered pipes? |
No idea, probably none, but it's not specified so it's somewhat like relying on implementation details.
|
No description provided.