Skip to content

linux: Add sendfile(2) #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2016
Merged

linux: Add sendfile(2) #266

merged 1 commit into from
Feb 14, 2016

Conversation

kamalmarhubi
Copy link
Member

No description provided.

@kamalmarhubi
Copy link
Member Author

r? @arcnmx
since why not

@kamalmarhubi
Copy link
Member Author

@homu r? @arcnmx

@kamalmarhubi
Copy link
Member Author

hrm

@kamalmarhubi
Copy link
Member Author

Oh, r? is part of rust-highfive I think.

@kamalmarhubi
Copy link
Member Author

r+

@kamalmarhubi
Copy link
Member Author

@homu r+

@homu
Copy link
Contributor

homu commented Feb 12, 2016

📌 Commit 191c506 has been approved by kamalmarhubi

@kamalmarhubi
Copy link
Member Author

@homu r-

@homu
Copy link
Contributor

homu commented Feb 12, 2016

⌛ Testing commit 191c506 with merge 77f3355...

homu added a commit that referenced this pull request Feb 12, 2016
@kamalmarhubi
Copy link
Member Author

woo it works

@kamalmarhubi
Copy link
Member Author

@arcnmx would you mind taking a look? :-)

@arcnmx
Copy link
Contributor

arcnmx commented Feb 12, 2016

Where's test_sendfile? o:

@kamalmarhubi
Copy link
Member Author

oh dear rebase fail

@kamalmarhubi
Copy link
Member Author

@arcnmx fixed

@arcnmx
Copy link
Contributor

arcnmx commented Feb 14, 2016

Pretty straightforward, looks good! My only comment is that the test would deadlock on a system without buffered pipes, but that's not the case on Linux so..!

@homu r+

@homu
Copy link
Contributor

homu commented Feb 14, 2016

📌 Commit 4680d50 has been approved by arcnmx

@homu
Copy link
Contributor

homu commented Feb 14, 2016

⚡ Test exempted - status

@homu homu merged commit 4680d50 into nix-rust:master Feb 14, 2016
homu added a commit that referenced this pull request Feb 14, 2016
@arcnmx
Copy link
Contributor

arcnmx commented Feb 14, 2016

Fancy, it used an older test result o:

@kamalmarhubi
Copy link
Member Author

Cool!

@arcnmx out of curiosity, what common systems don't have buffered pipes?

@arcnmx
Copy link
Contributor

arcnmx commented Feb 16, 2016

No idea, probably none, but it's not specified so it's somewhat like relying on implementation details.

Applications should not rely on a particular capacity: an application should be designed so that a reading process consumes data as soon as it is available, so that a writing process does not remain blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants