Exclude UContext::get(),set() on musl, not available from libc. #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you just disable those methods on the |
|
r? @fiveop |
justinlatimer
changed the title
|
@kamalmarhubi updated to only exclude functions that don't compile (and their imports) + squashed. Thanks! |
|
Thanks @justinlatimer! |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
May 20, 2016
Exclude UContext::get(),set() on musl, not available from libc. It looks like ``libc`` doesn't provide ``libc::getcontext`` or ``libc::setcontext`` when targeting musl, so I've excluded the ``ucontext`` module from being built when targeting musl which allows the module to be built successfully. Thanks!
|
@fiveop I decided that since this was more conservative that the original where the struct was also removed, it was fine. Hope that makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
libcdoesn't providelibc::getcontextorlibc::setcontextwhen targeting musl, so I've excluded theucontextmodule from being built when targeting musl which allows the module to be built successfully.Thanks!