ci: fix docker container check #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer version of docker no longer have the /.dockerinit file present when the container is executing, so that is no longer an option. When executing in a container, we do know that we will be executing as pid 1 -- this is probably not ever the case on the host system. Signed-off-by: Paul Osborne <[email protected]>
|
Given that the correct build (pr) is green, it would probably be alright to merge this. Let's see whether homu let's me. Why did the push build trigger? @homu r+ |
|
📌 Commit 90269e4 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Aug 11, 2016
ci: fix docker container check Newer version of docker no longer have the /.dockerinit file present when the container is executing, so that is no longer an option. When executing in a container, we do know that we will be executing as pid 1 -- this is probably not ever the case on the host system. r? @fiveop
I accidentally pushed my branch to the wrong remote (this repo) at first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of docker no longer have the /.dockerinit file present
when the container is executing, so that is no longer an option.
When executing in a container, we do know that we will be executing
as pid 1 -- this is probably not ever the case on the host system.
r? @fiveop