Skip to content

Bump minimum supported version of Rust #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Conversation

alexcrichton
Copy link
Contributor

Many crates are coalescing around 1.9.0 with the stabilization of std::panic,
and it helps remove the build script w/ rustc version parsing for now as well.

@posborne
Copy link
Member

Thanks Alex, I'm good with this change. Right now, CI is still testing (and passing) on 1.7.0 for some of the other non-x86 targets (another thing on my todo list). For the 0.8 release, I am fine with going toward 1.9.0 as the minimum supported version.

Can you update the CHANGELOG.md file to indicate that 1.9.0 is now the minimum supported version (there is a note for the pending release about 1.7.0 present currently).

Thanks!

The script checked for rustc >= 1.6.0, but the minimum supported version for
this crate is now 1.7.0
@alexcrichton
Copy link
Contributor Author

Oh! Actually reading more it looks like the version bump can be avoided. If the minimum version is 1.7.0 then the build script can still be removed as it's just checking for >= 1.6.0. Does that sound ok?

@posborne
Copy link
Member

Ah, sure enough. Sounds good to me! @homu r+

@homu
Copy link
Contributor

homu commented Oct 31, 2016

📌 Commit 81c42de has been approved by posborne

homu added a commit that referenced this pull request Oct 31, 2016
Bump minimum supported version of Rust

Many crates are coalescing around 1.9.0 with the stabilization of `std::panic`,
and it helps remove the build script w/ rustc version parsing for now as well.
@homu
Copy link
Contributor

homu commented Oct 31, 2016

⌛ Testing commit 81c42de with merge 74e3570...

@homu
Copy link
Contributor

homu commented Oct 31, 2016

☀️ Test successful - status

@homu homu merged commit 81c42de into nix-rust:master Oct 31, 2016
@kamalmarhubi
Copy link
Member

👍 I actually just did a git pull to go and remove the build script, and was confused about why I couldn't open it. Thanks @alexcrichton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants