Change sched_setaffinity's PID argument to pid_t #600
Conversation
|
I'd like to get the FreeBSD build passing, which should just require you re-pushing this branch. Otherwise I think it's RTM. |
The officially documented type, and the type in sched.h, for this argument is pid_t.
tokenrove
force-pushed
the
setaffinity-pid-argument
branch
from
b4ffeac to
d50f569
Compare
|
Is that better? |
|
No, buildbot is too "smart" for you. Repushing that old commit does not trigger a rebuild. But in this case it doesn't matter. That file is not even included in the FreeBSD build. |
|
Hm, bors isn't picking up the PR. Does the magic comment need to be double spaced? Let's try. bors r+ |
600: Change sched_setaffinity's PID argument to pid_t r=asomers I might be missing something as to why this argument was made `isize`, but there's nothing obvious from the commit history, and other calls that work with thread IDs in this library return `pid_t`, so hopefully this is a nit and not noise.
Build succeeded |
|
Yeah, we changed it recently so that the comment needs to be on its own. The idea if to make sure that people don't trigger builds because they happen to mention the possibility of saying "bors r+". |
|
Thanks @tokenrove for your PR! |
|
Thanks! I have a backlog of (only slightly less trivial) contributions to submit. This is a good reminder to do so. |
|
Excellent, look forward to reviewing them! |
I might be missing something as to why this argument was made
isize, but there's nothing obvious from the commit history, and other calls that work with thread IDs in this library returnpid_t, so hopefully this is a nit and not noise.