Skip to content

Use single threads for testing #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2017
Merged

Use single threads for testing #645

merged 1 commit into from
Jul 3, 2017

Conversation

Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Jul 3, 2017

I actually couldn't find a reference to CARGO_TEST_THREADS in the
current cargo codebase, but RUST_TEST_THREADS is definitely correct.
This should reduce some spurious failures on some platforms.

@Susurrus
Use single threads for testing
d2508e3 
I actually couldn't find a reference to CARGO_TEST_THREADS in the
current cargo codebase, but RUST_TEST_THREADS is definitely correct.
This should reduce some spurious failures on some platforms.
@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

The reason for Cross.toml is that Cross runs everything (but not on Mac) in a docker instance, so it uses a whitelist to passthrough environment variables.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

I'm actually just realizing that I don't think that trust has released since that feature was added, so this probably still doesn't do anything on non-Mac platforms.

@asomers
Copy link
Member

asomers commented Jul 3, 2017

Weird. It looks like @posborne set that variable correctly on his branch, but somehow it didn't get merged correctly.
Compare posborne/rust-nix@0e3ef36
to a8cf6cb

bors r+

bors bot added a commit that referenced this pull request Jul 3, 2017
@bors
Merge #645
baba879 
645: Use single threads for testing r=asomers

I actually couldn't find a reference to CARGO_TEST_THREADS in the
current cargo codebase, but RUST_TEST_THREADS is definitely correct.
This should reduce some spurious failures on some platforms.
@bors
Copy link
Contributor

bors bot commented Jul 3, 2017

Build succeeded

@bors bors bot merged commit d2508e3 into nix-rust:master Jul 3, 2017
@Susurrus Susurrus deleted the single_thread_testing branch July 13, 2017 19:14
@Susurrus Susurrus mentioned this pull request Jan 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Susurrus @asomers