-
Notifications
You must be signed in to change notification settings - Fork 696
Fix tier3s #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tier3s #662
Conversation
LGTM. Since these are all Tier 3, there's no harm in merging before 0.9.0, even though we won't have the relevant change to libc. bors r+ |
662: WIP: Fix tier3s r=asomers This handles the low-hanging fruit. rust-lang/libc#654 needs to land and there's a bit of work necessary for the syscall and ioctl errors.
bors r- |
Canceled |
I'm not quite done with this PR. It's annoying that bors doesn't ignore PRs that start with "WIP". GitLab has the nice feature that it won't let you merge PRs that start with WIP, it'd be nice if bors did that as well. |
I think this addresses everything that's not libc. Still need to figure out the |
bors r+ asomers |
662: WIP: Fix tier3s r=Susurrus This handles the low-hanging fruit. rust-lang/libc#654 needs to land and there's a bit of work necessary for the syscall and ioctl errors.
bors-ng can use labels for the WIP thing, if you want to use that. The syntax looks like: block-labels = [ "WIP", "DO NOT MERGE YET" ] You can also file an issue to block PRs based on their title. |
Build succeeded |
@asomers What do you say about adding "WIP" and "DO NOT MERGE" to the |
@Susurrus that sounds like a great idea. |
This handles the low-hanging fruit. rust-lang/libc#654 needs to land and there's a bit of work necessary for the syscall and ioctl errors.