Skip to content

Fix tier3s #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2017
Merged

Fix tier3s #662

merged 5 commits into from
Jul 9, 2017

Conversation

Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Jul 9, 2017

This handles the low-hanging fruit. rust-lang/libc#654 needs to land and there's a bit of work necessary for the syscall and ioctl errors.

@asomers
Copy link
Member

asomers commented Jul 9, 2017

LGTM. Since these are all Tier 3, there's no harm in merging before 0.9.0, even though we won't have the relevant change to libc.

bors r+

bors bot added a commit that referenced this pull request Jul 9, 2017
662: WIP: Fix tier3s r=asomers

This handles the low-hanging fruit. rust-lang/libc#654 needs to land and there's a bit of work necessary for the syscall and ioctl errors.
@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 9, 2017

bors r-

@bors
Copy link
Contributor

bors bot commented Jul 9, 2017

Canceled

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 9, 2017

I'm not quite done with this PR. It's annoying that bors doesn't ignore PRs that start with "WIP". GitLab has the nice feature that it won't let you merge PRs that start with WIP, it'd be nice if bors did that as well.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 9, 2017

I think this addresses everything that's not libc. Still need to figure out the arm-unknown-linux-musleabi problems, but not as part of this PR.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 9, 2017

bors r+ asomers

bors bot added a commit that referenced this pull request Jul 9, 2017
662: WIP: Fix tier3s r=Susurrus

This handles the low-hanging fruit. rust-lang/libc#654 needs to land and there's a bit of work necessary for the syscall and ioctl errors.
@Susurrus Susurrus changed the title WIP: Fix tier3s Fix tier3s Jul 9, 2017
@notriddle
Copy link
Contributor

bors-ng can use labels for the WIP thing, if you want to use that. The syntax looks like:

block-labels = [ "WIP", "DO NOT MERGE YET" ]

You can also file an issue to block PRs based on their title.

@bors
Copy link
Contributor

bors bot commented Jul 9, 2017

@bors bors bot merged commit c83b33a into nix-rust:master Jul 9, 2017
@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 9, 2017

@asomers What do you say about adding "WIP" and "DO NOT MERGE" to the block-labels setting for bors?

@Susurrus Susurrus deleted the fix_tier3s branch July 9, 2017 16:08
@asomers
Copy link
Member

asomers commented Jul 9, 2017

@Susurrus that sounds like a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants