Add a test for ppoll #780
Add a test for ppoll #780
Conversation
test/test_poll.rs
Outdated
| @@ -16,3 +18,22 @@ fn test_poll() { | |||
| assert_eq!(nfds, 1); | |||
| assert!(fds[0].revents().unwrap().contains(POLLIN)); | |||
| } | |||
|
|
|||
| #[cfg(any(target_os = "android", target_os = "dragonfly", target_os = "freebsd", | |||
There was a problem hiding this comment.
It'd be great to have comments either inline or a big summary one that explains what this is doing and any gotchas that exist in this test. With a project as diverse as nix and the complexity of some of the APIs it exposes I think it's helpful to provide comments.
Also, we generally use aligned indentation, one per OS, when there are too many OSes and they need to line wrap.
|
Looks like our Rust 1.14 problems are solved. Also, thanks a lot for those comments. I think they're helpful and hopefully weren't too much of a burden to write. Where's the gold star emoji!? bors r+ |
Build failed |
|
The failure looks related to Travis's build cache bors r+ susurrus |
Timed out |
|
bors r+ |
Build failed |
|
The build failed due to an ABI change at libc. I suspect that the ABI change was unintentional. If so, we should just wait for libc to revert it. If not, we'll have to make a matching update to nix. |
|
This is already being resolved at least partially at rust-lang/libc#813. See the comment discussion I've been having over there. If you're willing to finish off the fix there, it'd be awesome. |
|
bors r+ |
No description provided.