Skip to content

Reduce ios builds #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2017
Merged

Reduce ios builds #815

merged 2 commits into from
Dec 9, 2017

Conversation

Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Dec 8, 2017

Closes #669

@asomers
Copy link
Member

asomers commented Dec 8, 2017

Since we're not running tests on ios anyway, would it be possible to cross-build the ios targets from a Linux host?

@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 8, 2017

Yeah, I'll test it locally and we'll switch to that if so.

@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 8, 2017 

$ rustup target install aarch64-apple-ios
$ cargo build --target aarch64-apple-ios
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names --target aarch64-apple-ios --crate-type bin --crate-type rlib` (exit code: 101)
--- stderr
error: Error loading target specification: Could not find specification for target "aarch64-apple-ios"
  |
  = help: Use `--print target-list` for a list of built-in targets

This is the error I get. I'd think cross-compiling would be possible, but I don't know what to do with this error. Any ideas?

@asomers
Copy link
Member

asomers commented Dec 8, 2017

I think you need to use --target=foo, not --target foo

@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 9, 2017

That would've given me a different error. Both of those forms are equivalent.

Bryant Mairs added 2 commits December 8, 2017 17:55
Support building and testing multiple targets at once
112dca3 
Specifying multiple targets can be done by setting the
environment variable to a semi-colon delimited list of
targets.
Run all iOS builds on a single run
ea0952f
@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 9, 2017

This should be pretty uncontroversial.

bors r+

bors bot added a commit that referenced this pull request Dec 9, 2017
@bors
Merge #815
e5cc915 
815: Reduce ios builds r=Susurrus a=Susurrus

Closes #669
@bors
Copy link
Contributor

bors bot commented Dec 9, 2017

Build succeeded

@bors bors bot merged commit ea0952f into nix-rust:master Dec 9, 2017
@asomers
Copy link
Member

asomers commented Dec 9, 2017

I get the same error. It seems to me like rustup is installing std for aarch64-apple-ios, but not installing rustc.

@Susurrus Susurrus deleted the reduce_ios_builds branch December 9, 2017 18:01
@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 9, 2017 •
edited
Loading

See rust-lang/rustup#1303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Susurrus @asomers