Fix compilation on aarch64-unknown-linux-musl #912
Conversation
|
Didn't build on FreeBSD due to ENOSPC. If you push again, I think it'll build. Or, you can bypass bors and just press the merge button, just this once. |
|
Hi Gents, are you planning to merge this? It would be very helpful for us - we are trying to build on aarch64-musl and stuck on this one. |
|
@agend while this fixes nix now, it's likely this will break again in the future. If you really want to get proper support added to nix, please contribute to japaric/cross as we rely on that for our CI testing. bors r+ |
912: Fix compilation on aarch64-unknown-linux-musl r=Susurrus a=Susurrus trust/cross don't support this architecture, so it's non-trivial to add CI testing for this to nix, but this fixed it locally for me. Since it's not a supported platform, I haven't added anything to the CHANGELOG, since this could break before the next release. Co-authored-by: Bryant Mairs <[email protected]>
Build failed |
|
bors r+ |
912: Fix compilation on aarch64-unknown-linux-musl r=Susurrus a=Susurrus trust/cross don't support this architecture, so it's non-trivial to add CI testing for this to nix, but this fixed it locally for me. Since it's not a supported platform, I haven't added anything to the CHANGELOG, since this could break before the next release. Co-authored-by: Bryant Mairs <[email protected]>
| @@ -48,7 +48,7 @@ libc_bitflags!{ | |||
| /// Put the mapping into the first 2GB of the process address space. | |||
| #[cfg(any(all(any(target_os = "android", target_os = "linux"), | |||
| any(target_arch = "x86", target_arch = "x86_64")), | |||
| all(target_os = "linux", target_env = "musl", any(target_arch = "x86", target_pointer_width = "64")), | |||
| all(target_os = "linux", target_env = "musl", any(target_arch = "x86", target_arch = "x86_64")), | |||
There was a problem hiding this comment.
Emm, isn't this branch
all(target_os = "linux", target_env = "musl", any(target_arch = "x86", target_arch = "x86_64"))
already covered by
all(any(target_os = "android", target_os = "linux"), any(target_arch = "x86", target_arch = "x86_64"))
trust/cross don't support this architecture, so it's non-trivial to add CI testing for this to nix, but this fixed it locally for me. Since it's not a supported platform, I haven't added anything to the CHANGELOG, since this could break before the next release.