Skip to content

fix(extension): specify activation event #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

Ilanaya
Copy link
Contributor

@Ilanaya Ilanaya commented Dec 7, 2022

I'm primarily a JS/TS developer and even if your extension doesn't bother me in regular development (as it just doesn't intend to work there :) ), I think it shouldn't be activated on languages other than python.

Thanks for developing a great extension!

@njqdev
Copy link
Owner

njqdev commented Dec 12, 2022

Agreed, and thanks for the PR!

@njqdev njqdev merged commit e91c742 into njqdev:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants