Skip to content

Unmark deleted #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2021
Merged

Unmark deleted #334

merged 1 commit into from
Nov 23, 2021

Conversation

dyashuni
Copy link
Contributor

No description provided.

@dyashuni dyashuni mentioned this pull request Jul 29, 2021
Open
@liding1990
Copy link

Thanks a lot🌟

@dyashuni
Copy link
Contributor Author

dyashuni commented Jul 30, 2021 •
edited
Loading

@liding1990 You are welcome!) If you have any questions please let me know.

@luisbaia
Copy link

Any updates on this MR? I have been using this commit in particular, but it would be nicer to see this in develop/master :)

@yurymalkov
Copy link
Member

@luisbaia I'll check it within the week, sorry it takes that long.
Hopefully, things will start going much-much faster for the library in a week or two (I am going to parental leave for a few months and will focus on the repo).

yurymalkov
yurymalkov requested changes Sep 8, 2021
View reviewed changes
Copy link
Member

@yurymalkov yurymalkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I guess we should revert the save format. Please let me know what you think.

yurymalkov
yurymalkov reviewed Oct 7, 2021
View reviewed changes
Copy link
Member

@yurymalkov yurymalkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know what you think.
I can look into how pickle works tomorrow or we can just a note in the readme.

yurymalkov
yurymalkov reviewed Nov 16, 2021
View reviewed changes
yurymalkov
yurymalkov reviewed Nov 20, 2021
View reviewed changes
Copy link
Member

@yurymalkov yurymalkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! (though there should be one cosmetic change with not bumping the pickle format).

@yurymalkov yurymalkov merged commit 47bb1a1 into nmslib:develop Nov 23, 2021
@yurymalkov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurymalkov yurymalkov yurymalkov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyashuni @liding1990 @luisbaia @yurymalkov