LazyIndex #350
Merged
LazyIndex #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `LazyIndex` with the same API as `Index`. Useful when having multiple indices with lazy initialization.
|
Hi @urigoren , One thing I would change is the name of the file, since it directly collides with hnswlib name, which might cause ambiguity if imported within the folder. |
added 3 commits
November 30, 2021 10:14
Added a short description
|
Hi, @yurymalkov - done. Thanks! |
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
LazyIndexclass with the same API asIndex.Useful when having multiple indices with lazy initialization.
This also fixes the super annoying bug that crashes
hnswlib(without an exception) if callingadd_itemsorget_max_elementsbefore callinginit_index.This PR in its first version probably needs some work, I'd love to hear your feedback, thanks :-)