-
Notifications
You must be signed in to change notification settings - Fork 27
Feature/update snippets #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update snippets #116
Conversation
oh, nice! thanks so much for jumping in. this seems pretty useful!!! |
@fdncred, do you think it worth to add snippets for sed, awk in future PRs even when Nushell coverts the most (maybe all) their functionality? |
I'd prefer to keep the snippets nushell specific. I'm not sure I'd want to add snippets for a bunch of bash commands. |
Wow, what a lot of work you've put into this. I'm just wondering if these snippets will conflict with the current ide completion functionality we just added? I'm going to test it out in a little while but was wondering what you thought. |
I don't think they will complete for now. Snippets tend to provide command combinations, like in cases where data is read from stdin. AFAIK, LSP doesn't do that. But even when it will, we can just remove snippets and allow LSP provide better suggestions. For instance, what can be done: LSP can automatically insert pipe and placeholder for previous command if the next one reads from stdin (but just when there is nothing before). Snippets can't perform such analysis. ;) |
I finally got around to testing these. They're so cool!!! Thanks! |
fill
Snippets should not just provide access for some things, but allow reminding some syntax.