Skip to content

More conditional and loop snippets #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Nov 13, 2023

  • snippets for comparisons in if and while
  • snippets for iterating over ranges and files for for
  • simplify snippet names for builtins
  • remove snippets for list, table and range creations as they are simple constructs to type
  • use ${<number>:command ...} instead of ${<number>:block} and ${<number>:closure}

Add snippets for comparisons
Add comparison snippets.
Add snippets for ranges and files.
Reduce snippet amount by removal of some snippets related to
syntax constructs.
@@ -317,7 +289,7 @@
"}"
]
},
"def-env builtin": {
"def-env": {
Copy link
Contributor

@fdncred fdncred Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def-env is deprecated in favor of def --env now. There's also a def --wrapped now that takes the place of extern-wrapped.

@fdncred
Copy link
Contributor

fdncred commented Nov 13, 2023

Good to see you back. Thanks!

@fdncred
Copy link
Contributor

fdncred commented Nov 13, 2023

Can you add a def --wrapped in the same manner that you just changed def --env? If we can get that in, I'll land this.

@EmilyGraceSeville7cf
Copy link
Contributor Author

Done. :)

Copy link
Contributor

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fdncred fdncred merged commit 4f2b6e9 into nushell:main Nov 13, 2023
@fdncred fdncred mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants