Skip to content

Fix use syntax #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 14, 2023
Merged

Fix use syntax #79

merged 9 commits into from
Feb 14, 2023

Conversation

glcraft
Copy link
Contributor

@glcraft glcraft commented Feb 14, 2023

#78

Add braced symbols import

image

Add use filename with module name highlight

image

@fdncred
Copy link
Contributor

fdncred commented Feb 14, 2023

Looking at those regular expressions makes me want to vomit. 😆 Good work, Thanks! Let's land this and see how it goes.

@fdncred fdncred merged commit 3cc8251 into nushell:main Feb 14, 2023
@fdncred
Copy link
Contributor

fdncred commented Mar 21, 2023

@glcraft I just noticed that these use config points are colored wrong. I'm wondering if it has to do with this PR?
image

@glcraft
Copy link
Contributor Author

glcraft commented Mar 21, 2023

@glcraft I just noticed that these use config points are colored wrong. I'm wondering if it has to do with this PR? image

Yes, the issue occurs right here
image

Replace by "^\\s*(?:export )?use\\b". With the word boundary, it will not parse use_...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants